Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have requested a review from the appropriate persons
I have checked that my changes work in the preview
I have checked that the rest of the site is still functioning in the preview
I have checked that my content/code is consistent with existing content/code
I have used components in the places and ways they are intended (see the readme)
I have formatted all of my code with Prettier
Fixes Add Prettier + EsLint to Github Actions #369
Moved some dependencies which were in
dependencies
todevdependencies
to prevent them clogging up thedependencies
list since they are not needed in productionRan
yarn format
which purely formats code and nothing else (no harm to code logic), affects majority of the files in this pull requestCreated new command called
yarn lint
which allows devs to run eslint in consoleBoth
yarn lint
andyarn format
are implemented in a Github Actions workflow to run on every PR to ensure that devs are following correct formatting and EsLintRan linting throughout the repo and fixed as many issues I could without significantly changing things
Much of the changes with EsLint consisted of changes with
==
vs===
,!=
vs!==
and unused variables/importsThere are still some errors/warnings to be fixed, which hopefully someone more knowledge about the codebase can tackle, I have pasted the report below:
https://github.com/3b1b/3Blue1Brown.com/actions/runs/7245820114/job/19736572822?pr=370
Once these errors are removed, then if desired an admin of the repo can enable branch protection rules with the status checks to ensure that formatting and linting pass before a developer can merge their code